Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templating to initContainers and sidecarContainers #230

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

yungwood
Copy link
Contributor

@yungwood yungwood commented Sep 1, 2024

Adds the ability for users to use templating within the initContainers and sidecarContainers values.

Summary of changes:

  • renames existing extraDeploy.render helper function to tplRender
  • removes multiple initContainers keys in deployment when initContainers is specified with rclone backups
  • uses tplRender function to process initContainers and sidecarContainers
  • add templating examples to values.yaml
  • add initContainers, sidecarContainers and extraDeploy to values schema

@yungwood
Copy link
Contributor Author

yungwood commented Sep 1, 2024

I created this MR because I was wanting to add minecraft-prometheus-exporter as a sidecar container and use templating functions to use the chart's rcon secret as an env variable.

@yungwood yungwood force-pushed the feat/minecraft-container-templating branch from 6dcc1ef to b31f45c Compare September 1, 2024 07:50
@yungwood yungwood changed the title Add templating to initContainer and sidecarContainer Add templating to initContainers and sidecarContainers Sep 1, 2024
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you bump the chart versions please.

@yungwood
Copy link
Contributor Author

yungwood commented Sep 9, 2024

Sorry about that, chart version bumped

@itzg itzg merged commit 7531b97 into itzg:master Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants