Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Spawn protection setting bugged #241

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Conversation

thomascizeron
Copy link
Contributor

See Issue #227

Also resorb mc-router envBoolMap, can revert this if not wanted.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay reviewing this. This looks really good!

Please bump the chart versions to next patch (3rd position) and this will be ready to merge.

@thomascizeron
Copy link
Contributor Author

I've rebased the branch and re-bump the chart version because it has changed since

@itzg itzg merged commit 5eb6182 into itzg:master Dec 13, 2024
1 check passed
@itzg
Copy link
Owner

itzg commented Dec 14, 2024

I just wanted to note that I forgot about the special value "default" that needed to be taken into account by the variable mapping helper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants