Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix: #421 dataview task mouseGripDown #496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bayerju
Copy link

@bayerju bayerju commented Jul 14, 2024

Fix grap of dataview inserted tasks

Closes #421
I tested it with the task plugin. It works with tasks scheduled by the task plugin and tasks in the daily note. I did not figure out, if it is supposed to work for mobile as well.

Manual tests I did:

Steps before testing

  • install dataview plugin
  • instll tasks plugin
  • run obsidian-day-planner

Tests

  • put a task in the daily note and go to the timeline, where you grap it from the unscheduled tasks and put it on a timeslot (worked before, but since this I worked on affecting code I made sure it still works)
  • go to any note and add a task. Schedule it for a certain day and put the hashtag "#tasks" in the file. Go to the timeline and edit the dataview filter to include the "#tasks" hashtag. now go to the previously chosen day and grap the task from the unscheduled tasks. it should work the same, like the task in the daily notes now.

Comments

I am not quite happy with the naming, but I did the best I could, without a refactor. Since the Tasks plugin uses the naming scheduled for days and this plugin uses the naming scheduled for timeslots.
Also I did not really get the naming starttime, which seems to be a date and not a time. I hope I did not get this wrong and break anything else.

@bayerju bayerju changed the title fix: #421 dataview task mouseGripDown WIP: fix: #421 dataview task mouseGripDown Jul 16, 2024
@bayerju
Copy link
Author

bayerju commented Jul 16, 2024

just found a bug, I will fix it on thursday. So dont bother reading this till then.

@ivan-lednev ivan-lednev force-pushed the main branch 2 times, most recently from 648a446 to ca91e6e Compare September 28, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tasks found using Dataview Source, both folder -"Tasks" and tags -"#GTD", can not be dragged and dropped
1 participant