Model presentation #62
Conversation
lmichel
commented
Dec 5, 2024
lmichel
commented
- remove 'abstract dimensional grouping' for errors
- set errors (DataType) as attributes instead of composition
- add a super class for Photometric properties
There was a problem hiding this comment.
commit photometric super class: class diagram :
I suggest that the relation between PhotometricProperty ( super class) and PhotCal should be maintained .
Photcal does not apply only to Brightness and should also apply to the Color class or other derived classes of PhotometryProperty.
|
Agree with Mireille, I'll restore the PHOTCal link for colors |
There was a problem hiding this comment.
I'm not sure how this file relates to desc.mango.vo-dml.xml, but:
- neither appears to have the text from desc.error.PropertyError.distribution.txt in them
- other descriptions do not match (eg: Ellipse here does not have the new text seen in the other).
| This is not enforced by the model. The definition of the ellipse attribute is imported from \texttt{coords:Ellipse}. |
There was a problem hiding this comment.
- I think the definitions match only for the standard a celestial coordinate space (see comments on issue Error types and relation to Measurement model Uncertainty #60.
- Ellipse is in Measurements, so is meas:Ellipse
| @@ -1146,6 +1161,20 @@ As long as the vocabulary is not set, the possible values of this attribute are | |||
| <maxOccurs>1</maxOccurs> | |||
| </multiplicity> | |||
| </attribute> | |||
| <attribute> | |||
There was a problem hiding this comment.
I'm guessing that this metadata hasn't been needed in practice for the use cases, but added after re-reading the confidenceLevel discussion from Meas RFC1. ?? If this is associated with the confidenceLevel, they should be encapsulated in an object/datatype.
| </attribute> | ||
| <attribute> | ||
| <vodml-id>EpochPositionErrors.properMotion</vodml-id> | ||
| <name>properMotion</name> | ||
| <description> Position error; can be an ellipse, a correlation matrix or a covariance matrix.</description> |
There was a problem hiding this comment.
properMotion and position are both described with the same text as "Position error", is this intentional?
| <name>properMotion</name> | ||
| </attribute> | ||
| <attribute> | ||
| <vodml-id>EpochPositionErrors.Position</vodml-id> |
There was a problem hiding this comment.
'Position' should be lowercase
| @@ -904,58 +890,62 @@ As long as the vocabulary is not set, the possible values of this attribute are | |||
| <vodml-id>EpochPositionErrors</vodml-id> | |||
| <name>EpochPositionErrors</name> | |||
There was a problem hiding this comment.
The migration from composition to attribute includes a change to the multiplicity of the different errors. This now requires errors for all properties where before they were not. Is that intentional?
