This repository has been archived by the owner on Feb 7, 2022. It is now read-only.
Update to also support PhantomJS v2.0 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just tried to clone confess.js and use it with the current version of PhantomJS. Looks like they made a backwards incompatible change with v2.0 in that they no longer support phantom.args but rather require the use of system.args Also they have added the script name as the first argument.
I've tried to add the minimal code to confess.js to get it to run on v2.0 while maintaining backwards compatibility so people can still run it on v1.2, etc.