added yaml files and fixed notebook #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshalgren
pushed a commit
that referenced
this pull request
Aug 3, 2021
* added compute function for diffusive calls and splitting reservoirs from subnetworks * updated compute.py calls to diffusive network and network splitting * fix to handle q0_sub edge case when the offnetwork upstream is a reservoir * deallocate bfuf_g array in diffusive.f90 and put q0_sub edge case fix in check if waterbodies_df is not empty * lower level fix for offnetwork reservoir initial conditions * fix for stream downstream of reservoir to run diffusive * hack to fix reservoir break issue * passing downstream segments of reservoir list to diffusive.pyx * reservoir boundary condition data passing * getting upstream reservoir values in diffusive.pyx * minor fixes to run diffusive croton with removing prints of eliminated vars * removed debug print statements * removed debug prints Co-authored-by: David Mattern <[email protected]> Co-authored-by: David Mattern <[email protected]> Co-authored-by: awlostowski-noaa <[email protected]> Co-authored-by: Adam Wlostowski <[email protected]> Co-authored-by: David Mattern <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outputs interactive graphs of top 25 courant values, added yaml files, timesteps for json and yaml files set to 10, 60, and 300.