Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cpu_threads to model.yaml #1845

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

vansangpfiev
Copy link
Contributor

This pull request introduces a new configuration parameter, cpu_threads, to various parts of the codebase, and refactors the writeKeyValue method to WriteKeyValue for consistency. The most important changes include updates to the ModelConfig structure, YAML handling, and test cases.

New Configuration Parameter cpu_threads:

Refactoring writeKeyValue to WriteKeyValue:

Test Case Updates:

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review January 8, 2025 02:19
Copy link
Contributor

@nguyenhoangthuan99 nguyenhoangthuan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants