Enable FastFixtureTestCase on Django 1.8+ #258
Conversation
Test fails against Django 1.8+
Sites are referenced in the tear down for FastFixtureTestCase
In the scenario that a test file does something like::
from django_nose.testcases import FastFixtureTestCase as TestCase
And then has a bunch of fixture related test cases but *one* test case
that doesn't have fixtures - because why import another test class for
that one little test case? - in that scenario the testcase will raise
an error iterating over a NoneType. Ensures that fixtures are only
handled when actually present.
|
any issues with this PR? |
|
Only that I avoid |
|
currently attempting to implement the changes. does this PR need test coverage? what will make you confident? |
|
I'd like someone that actually uses |
|
I've been using this patch with a project running Django 1.8.12 since creating the pull request. Would it be worthwhile adding I totally understand why you're not eager to include this. In my case the project using this feature has a legacy test suite that would take a significant effort to rewrite, relies on large fixture files, and originally took over 90 minutes to run in full (now under 60 seconds after trebling the number of tests). |
|
@bennylope, I'm glad it works for you. I need a second project to test it out to confirm that the fixes are at least applicable to one other codebase. |
|
Hi @bennylope , I have a question with this PR. Does removing transaction completely solves the problem ??? I think that is for setting up database right??/ |
This changeset allows the
FastFixtureTestCaseto be used on Django 1.8+.This is not a rewrite or a comprehensive set of tests for the test case class. It is however an incremental move forward testing a baseline, can
FastFixtureTestCasebe used in tests? The first commit adds the basic test - which will fail - and next three, specifically 8cb7e91 apply the changeset to pass.I'm sure the
FastFixtureTestCasecould use some additional work, certainly additional testing, getting it working seems like a good start.Also solves the issue in #200 where no fixtures are specified and the test case fails (a necessary fix for the application I'm supporting).
Does not solve problems specifically for #162 or #208 as those issues reference now unsupported versions of Django. I'd reckon those issues could probably be closed since they're out of date now.