Skip to content

Commit

Permalink
Merge pull request #496 from fcojfernandez/require-jdk-17
Browse files Browse the repository at this point in the history
Make jdk-17 required
  • Loading branch information
fcojfernandez authored Jan 7, 2025
2 parents 9f6f0f1 + 41f98d9 commit 714a976
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 6 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,21 @@ jobs:
java-version: '17'
check-latest: true
cache: 'maven'
# https://github.com/jenkins-infra/github-reusable-workflows/issues/36
- name: Set up Maven
run: |
wget --no-verbose https://downloads.apache.org/maven/maven-3/$MAVEN_VERSION/binaries/apache-maven-$MAVEN_VERSION-bin.tar.gz
echo $CHECKSUM apache-maven-$MAVEN_VERSION-bin.tar.gz | sha512sum --check
tar xzf apache-maven-$MAVEN_VERSION-bin.tar.gz
rm apache-maven-$MAVEN_VERSION-bin.tar.gz
sudo mv apache-maven-$MAVEN_VERSION /opt/maven
sudo rm -f /usr/bin/mvn
sudo ln -s /opt/maven/bin/mvn /usr/bin/mvn
mvn --version
env:
MAVEN_VERSION: 3.9.9
# https://downloads.apache.org/maven/maven-3/3.9.9/binaries/apache-maven-3.9.9-bin.tar.gz.sha512
CHECKSUM: a555254d6b53d267965a3404ecb14e53c3827c09c3b94b5678835887ab404556bfaf78dcfe03ba76fa2508649dca8531c74bca4d5846513522404d48e8c4ac8b
- name: Generate coverage with JaCoCo
run: mvn --batch-mode clean verify jacoco:prepare-agent test integration-test jacoco:report

Expand Down
1 change: 0 additions & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@ buildPlugin(useContainerAgent: true,
artifactCachingProxyEnabled: true,
configurations: [
[platform: 'linux', jdk: 21],
[platform: 'linux', jdk: 11],
[platform: 'windows', jdk: 17],
])
12 changes: 7 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.87</version>
<version>5.3</version>
<relativePath />
</parent>

Expand Down Expand Up @@ -45,8 +45,8 @@
<revision>4</revision>
<changelist>999999-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
<!-- update the jenkins-bom version when updating -->
<jenkins.version>2.426.3</jenkins.version>
<jenkins.baseline>2.479</jenkins.baseline>
<jenkins.version>${jenkins.baseline}.1</jenkins.version>
<spotless.check.skip>false</spotless.check.skip>
<spotbugs.effort>Max</spotbugs.effort>
<configuration-as-code.version>1836.vccda_4a_122a_a_e</configuration-as-code.version>
Expand All @@ -59,8 +59,8 @@
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.426.x</artifactId>
<version>3208.vb_21177d4b_cd9</version>
<artifactId>bom-${jenkins.baseline}.x</artifactId>
<version>3850.vb_c5319efa_e29</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down Expand Up @@ -136,6 +136,7 @@
<artifactId>jackson-databind</artifactId>
</exclusion>
<exclusion>
<!-- consume from Jenkins core -->
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
Expand All @@ -154,6 +155,7 @@
<scope>test</scope>
<exclusions>
<exclusion>
<!-- consume from Jenkins core -->
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
Expand Down

0 comments on commit 714a976

Please sign in to comment.