Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also support all S3_PING configuration options as environment variables #374 #399

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Jan 15, 2025

No description provided.

@rhusar rhusar force-pushed the environment-variables branch from c78c88c to 580c30b Compare January 15, 2025 15:02
@rhusar rhusar marked this pull request as ready for review January 16, 2025 13:19
@rhusar rhusar requested a review from pferraro January 16, 2025 16:21
@rhusar
Copy link
Member Author

rhusar commented Jan 16, 2025

@pferraro if I can get a 2nd pair of 👁️ s. Thx

Copy link

@pferraro pferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhusar rhusar merged commit 31ba502 into jgroups-extras:main Jan 16, 2025
12 checks passed
@rhusar rhusar deleted the environment-variables branch January 16, 2025 17:03
@rhusar
Copy link
Member Author

rhusar commented Jan 16, 2025

Thanks @pferraro

@rhusar rhusar added this to the 3.0.1.Final milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants