Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource sentry_release_deployment #265

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

mvantellingen
Copy link

This resource creates a new deployment for a specific release and environment in sentry.

@jianyuan
Copy link
Owner

jianyuan commented Jan 23, 2023

@mvantellingen I'm getting a 404 error when I run your test locally. I think we need a sentry_release resource and data source too.

From the source code, the create release deployment endpoint is checking to see if a release of a particular version exists.

I'm happy to merge this PR as is on the assumption that a release was created elsewhere. What do you think?

@mvantellingen
Copy link
Author

@jianyuan what we do (and I assume is the most common scenario) is build the release artifacts with for example a GitHub action, create the release also with a GitHub action and then do the actual deployment using Terraform.

I'm not sure there is a valid use-case for creating releases with Terraform

@mvantellingen
Copy link
Author

@jianyuan I merged your suggestion. Anything else I can do to help get this released? If you need some time available for this then no worries.

mvantellingen and others added 2 commits June 14, 2023 13:50
This resource creates a new deployment for a specific release and
environment in sentry.
@jianyuan jianyuan force-pushed the main branch 4 times, most recently from 22896ae to 99fb59f Compare May 6, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants