Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SerializationTest.php #752

Closed
wants to merge 1 commit into from

Conversation

simonsolutions
Copy link
Contributor

Add test for DateTime with milliseconds in product fee estimation API request

@jlevers
Copy link
Owner

jlevers commented Jul 9, 2024

A couple comments:

@simonsolutions
Copy link
Contributor Author

It tests the function that returns milliseconds, that's what you wanted testing directly the function and with the result the millisecond conversion. Before adding the milliseconds time format the response threw an error.

I can't merge both PR's - not shown the option for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants