Feature/persistent term #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schema in a GraphQL engine has the property that it is very rarely updated if at all, but is read into every process using GraphQL calls. To avoid copying the term into every process, we store this as a persistent_term upon schema validation. This avoids the copy into the process and shares the term for every process in the system. The major gain is not the avoidance of ETS locking, but avoiding putting the schema on the heap. For large queries, this doesn't matter, but smaller queries which touch lots of the schema, this should lead to a considerably leaner process.
All calls to this function can be served by graphql_schema:lookup/1 easily. This streamlines the code.
If we don't have persistent_term support, the call will fail. Back it by the older ETS lookup. This will make the system run on pre OTP 21.2 machines as well as provide a forward path.
Fixes a dialyzer warning in the system.
Move specifications under the ifdef's so we can make the dialyzer happy on older releases.
The reason we use persistent term is to avoid copying the schema more than making things run fast. So use this construction to handle OTP 21.0 to OTP 21.1 versions. We can lift this restriction later on when people are more likely to have upgraded to newer versions. And when OTP 22.0 comes out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.