[Redesign] Additional fixes to avoid bottom system UI #1001
Conversation
…ews or screens with the nowplayingbar when nothing is playing.
|
Nice, thanks for that. IMO we can even add a good chunk of additional padding, so that the last list element scrolls to about half the screen height. That very clearly signals that the end of the list has been reached. I've been meaning to add this for a while, but never got around to it. Adding a static (and configurable) bottom padding should be easy, looking at the code. Also, I noticed that the now playing bar still sometimes shifts up when loading. I remember you adding a missing SafeArea a while back, so I'm not sure what the issue is there... |
|
I've added an argument for specifying additional bottom padding, but upped the padding on anything. Half a screen seems a bit much, I'd lean towards 1 or two items of overscroll max myself, maybe even less. Although the scroll physics do a decent job of communicating the end of lists already which is presumably why the system apps don't feel the need for overscroll - the only place it feels off is the album lists where it always feels like there could be a track hidden behind the now playing bar even though there isn't. Feel free to tune it however you like, but I don't feel the need to mess with it much myself. Regarding the now playing bar, I don't see a shift in this build. Is it possible you're thinking of the actual beta build, which still doesn't have that change released? |
|
Yeah half a screen might be a bit much. I like how the contacts app does it (around two items). Some apps, like Spotify, add additional content at the bottom, but that's not a great solution for Finamp in its current state. I'll play around with it, but it's a small detail anyway. Oh and the SafeArea fix feels like an age ago, is it really not released yet? In that case I'll try to push a release towards the end of this week, since it's been too long! |
|
Okay, went with a padding of 32, slightly less than the default list tile, but gives a nice visual indication that no other tile is coming after the last one. Also didn't look weird on the artist screen, where larger paddings did. I had to exclude the drawer, the padding doesn't do any good there. Everything else seemed to behave as it should. |
Fixes missing bottom padding to allow scrolling all elements past the bottom system UI when now playing bar is inactive and on all screens using CustomScrollViews.