-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👀 Disable scrollbar when not sorting by name #522
Conversation
I can't figure out what the actual change is. Which scrollbar is being disabled and why? 🤔 |
Apologies, the PR is definitely messy. I should've redone it with two separate commits. |
Okay, now I get it. Makes sense 👍🏻 |
a908185
to
bac7eb3
Compare
Did just that myself now 😄 |
Awesome. I think we can ignore the failing build for now, that problem needs to be solved somewhere else... |
It's probably because I rebased onto the latest main.. |
The GitHub Action always uses the latest stable Flutter, which might've changed something tiny that broke the build |
Yeah I fixed it in a different PR and that's now merged on main. |
I think this can be merged. I'll do that in a few days unless anyone sees a problems with it... |
That would be great, thank you! Oh, and if you need me to rebase in the future, just give me a heads-up and I'll do that. It's probably cleaner than creating those merge commits. |
Merged, thanks :) |
Probably, bit busy though at the moment. Maybe within the next few days. |
Apologies for the messy PR, there was apparently a lot of incorrectly formatted code as well which Android Studio auto-formatted for me.