Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide a docker ready environment for developing locally #214

Closed
wants to merge 2 commits into from
Closed

feat: Provide a docker ready environment for developing locally #214

wants to merge 2 commits into from

Conversation

TheoD02
Copy link
Contributor

@TheoD02 TheoD02 commented Jan 4, 2024

Docker-Ready Development Environment

Overview

This PR permit to includes Docker support to streamline the local development process. With Docker, contributors can set up a ready-to-use development environment without the need to install any tools locally.

I don't know if this can bu useful for all of us, but is a thing that is missing for my case, feel free to close if PR is not suitable

To know

I've used ubuntu:22.04 as docker base image, because the PHP 8.2 image doesn't contain the SIGUSR2 constant, so if anyone has a solution I'd love to hear from you!

How to Use Docker for Local Development

  1. Clone this repository:

    git clone https://github.com/jolicode/castor
  2. Navigate to the project directory:

    cd castor
  3. Build and Running the Docker Container:

    docker compose up -d --build --wait
  4. Run bash into the Docker container:

    docker compose exec php bash

@lyrixx
Copy link
Member

lyrixx commented Jan 5, 2024

Hello @TheoD02

Thanks for your contribution. I'm really sorry to said that, But I don't like this PR (but I like your others PRs).

I think it's not the responsibility of every repository to provide a development docker environment

So I'm 👎🏼 for merging it. But let's wait for more feedback

@pyrech
Copy link
Member

pyrech commented Jan 5, 2024

I agree with lyrixx here, even if your PR and suggested environment are nicely documented, I don't think this repository should explain how to setup a PHP environment. So I'm vote 👎 too

@lyrixx
Copy link
Member

lyrixx commented Jan 5, 2024

I'm closing it for the reason explained.

@lyrixx lyrixx closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants