Identify 3D models using an integer ID instead of a name #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, update the tests.
That also changes the semantics of the `% 1` operation and causes the calculated UVs to be incorrect.
- Rename `SignedDistanceFunction` to `SignedDistanceField` - Make empty mesh warnings all consistent - Add basic SDF boolean operation tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For programs with a very large number of instances, a lot of time is spent collecting the models. A significant amount of this seems to be the cost of building the names for the models and then looking these up in the
ModelsCache. It would be quicker to construct numeric IDs rather than string names. This PR implements that using theHASH_functions frommodels.pxd.On one of my examples, which has 60k instances of about 10 different models – including 6 or 7 that are the result of
!trimoperations – the render time goes from ~35ms per frame to ~28ms.