Varnish 3 #51
Merged
Varnish 3 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "gauge should be a Counter" error doesn't present until the Prometheus module attempts to gather the metrics for display (see https://github.com/prometheus/client_golang/blob/4efc3ccc7a660996803fff4721a2643b33dc3f77/prometheus/registry.go#L610). This test runs through the test varnishstat files and collects them into a Prometheus registry and then calls `Gather()` to ensure there are no errors.
This is no longer used in Varnish 4+ as the metric was renamed to `n_bans` rather than `n_ban`. And in Varnish 3 it breaks as the `n_ban` and `n_ban_gone` are `i` (Integer) flags while all the other `n_ban*` metrics are `a` (Accumulator) flags. (See https://github.com/varnishcache/varnish-cache/blob/3.0/include/vsc_fields.h#L142-L148)
|
Your PR is included in the 1.5.2 release, thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error when scraping metrics from Varnish 3:
Also adds a Prometheus gather test which replicates that error.
Resolves #50