Calculate hitrate the same way varnishstat does it #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the client request rate for hitrate calculation is not accurate because there are things like ESI that increase hits without increasing client requests. This is how varnishstat does it: https://github.com/varnishcache/varnish-cache/blob/9b5332e2a2e0c5d3a0485704164ea9d3cebe4b68/bin/varnishstat/varnishstat_curses.c#L300
DracoBlue
suggested changes
Jun 4, 2020
dashboards/jonnenauha/dashboard.json
Outdated
| @@ -114,6 +114,7 @@ | |||
| "targets": [ | |||
| { | |||
| "expr": "avg(( rate(varnish_main_cache_hit{instance=~\"^($varnish_instance).*\"}[5m]) / rate(varnish_main_client_req{instance=~\"^($varnish_instance).*\"}[5m]) ))", | |||
There was a problem hiding this comment.
you need to remove this line if you want to replace it
DracoBlue
reviewed
Jun 4, 2020
Co-authored-by: DracoBlue <[email protected]>
|
I've merged another PR that fixed this same issue. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the client request rate for hitrate calculation is not accurate because there are things like ESI that increase hits without increasing client requests. This is how varnishstat does it: https://github.com/varnishcache/varnish-cache/blob/9b5332e2a2e0c5d3a0485704164ea9d3cebe4b68/bin/varnishstat/varnishstat_curses.c#L300