[NFG] Fix for newer Varnish versions #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers" object
```
{
"version": 1,
"timestamp": "2020-09-22T11:55:40",
"counters": {
"MGT.uptime": {
"description": "Management process uptime",
"flag": "c",
"format": "d",
"value": 4725
},
...
```
Merged
|
Fixed the code and added a test here #64 |
|
Thanks @johanneswuerbach for helping out, i can get your version to compile, but i still get no metrics and this warning: |
|
Sorry @jangrewe I relied only on the passing tests, but they actually didn't ensure something is scraped. Pushed another commit, which should ensure that something is scraped and fixes the scraping. |
|
Yes, thank you, everything's working fine again! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Varnishstat's JSON output now has a
countersobject that contains all the metrics (and aversionfield to indicate this).Unfortunately my GoFu is not that good to quickly fix it, but maybe i'll figure it out later.
I guess you should be able to get this to compile in no time. ;-)