Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a separate target reference to push in kit push #685

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amisevsk
Copy link
Contributor

Description

Allow specifying a separate push target, so that you don't have to tag ModelKits locally before pushing (similar to what podman--but not docker--does).

  • Push locally-tagged image to remote (same as what we currently do):
    kit push registry.example.com/myorg/mymodel:mytag
    
  • Push a local image to the same remote without tagging first
    kit push localmodel:latest registry.example.com/myorg/mymodel:mytag
    

Linked issues

I didn't create an issue for this one yet, but I figured it'd be useful while working on #684, which by default tags according to the HF repo

Add a two-argument version of `kit push` that allows pushing local
modelkits without explicitly tagging them first.

When specified with one argument, e.g.

  kit push example.com/myorg/myrepo:mytag

we'll push the locally-tagged ModelKit as before. When specified with
two arguments, e.g.

  kit push myorg/mymodel:mytag example.com/neworg/newrepo:newtag

we'll push the locally tagged model to the remote registry under a
differente repository
@amisevsk amisevsk requested a review from gorkem January 10, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant