Remove Import Cycle for ValueTypes #549

georg-schwarz · 2024-04-16T14:54:57Z

... by using the services dependency injection mechanism.

Adds value type wrapping to the WrapperFactoryProvider and introduces a PrimitiveValueTypeProvider to manage the singleton instances of our primitive value types. Removes the singleton handling that we used before by exporting instances (now handled by the introduced providers)

The remaining changes follow these bigger changes.

…uters

libs/execution/src/lib/constraints/executors/allowlist-constraint-executor.ts

package.json

libs/language-server/src/lib/jayvee-module.ts

libs/language-server/src/lib/builtin-library/stdlib.ts

libs/language-server/src/lib/ast/wrappers/wrapper-factory-provider.ts

rhazn

Just a very high level review as I think is understandable with the amount of files. But the overall changes look okay to me and I didn't see an obvious issue 😅 . Good job 👍 .

libs/execution/src/lib/blocks/composite-block-executor.ts

libs/execution/src/lib/constraints/executors/allowlist-constraint-executor.ts

libs/language-server/src/lib/ast/wrappers/value-type/primitive/collection/index.ts

libs/language-server/src/lib/ast/wrappers/value-type/primitive/index.ts

libs/language-server/src/lib/ast/wrappers/wrapper-factory-provider.ts

libs/language-server/src/lib/jayvee-module.ts

…tory

georg-schwarz added 19 commits April 15, 2024 14:53

Refactor value type creation to be used via WrapperFactoryProvider

74416b0

Create TransformExecutor with ExecutionContext

28f47d8

Remove unnecessary parameter from AtomicValueType.getConstraints

0dffbc8

Adapt test to changes to TransformExecutor

af72beb

Bottom-up exports of value types

6a60b4c

Remove deprecated method createPrimitiveValuetype

48ecbd0

Export EmptyCollection

d594b84

Add PrimitiveValuetypeContainer to ValueTypeWrapperFactory

fa58a67

Add PrimitiveValuetypeContainer to JayveeServices

37b5704

Rename PrimitiveValueTypeContainer

dc4b16f

Introduce PrimitiveValueTypeProvider and add to ExecutionContext

cf5abf9

Use PrimitiveValueTypeProvider instead of WrapperFactory in executors

ba89015

Use PrimitiveValueTypeProvider instead of WrapperFactory in type comp…

d68022f

…uters

Use PrimitiveValueTypeProvider in validations

6814d00

User PrimitiveValueTypeProvider in validations and wrappers

a8f46ee

User PrimitiveValueTypeProvider in EvaluationContext

4fd1896

User PrimitiveValueTypeProvider to refer to EmptyCollection

4688b37

Remove fields Primitives and EmptyCollection from WrapperFactoryProvider

e78d52a

Adapt tests to changes

3522961