Add material science domain #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libs/language-server/src/stdlib/domain/material-science/MatSciDoiStandardizer.jv
Outdated
Show resolved
Hide resolved
TungstnBallon
force-pushed
the
material-science-domain
branch
from
74a9510 to
94532de
Compare
rhazn
requested changes
Jun 28, 2024
libs/language-server/src/stdlib/domain/material-science/MatSciDoiStandardizer.jv
Outdated
Show resolved
Hide resolved
libs/language-server/src/stdlib/domain/material-science/MatSciDoiStandardizer.jv
Outdated
Show resolved
Hide resolved
libs/language-server/src/stdlib/domain/material-science/MatSciDoiStandardizer.jv
Outdated
Show resolved
Hide resolved
libs/language-server/src/stdlib/domain/material-science/MatSciDoiStandardizer.jv
Outdated
Show resolved
Hide resolved
libs/language-server/src/stdlib/domain/material-science/MatSciValueTypes.jv
Outdated
Show resolved
Hide resolved
libs/language-server/src/stdlib/domain/material-science/MatSciValueTypes.jv
Outdated
Show resolved
Hide resolved
|
@georg-schwarz @joluj I assume this should be fine, but to make sure: Are you okay with us moving the common value types and blocks we arrived at from SWC into a basic material science domain extension for Jayvee? |
- rename files - improve documentation - improve naming
rhazn
approved these changes
Jun 30, 2024
|
I think in this repository you should be able to merge yourself after approvals, can you try @TungstnBallon ? |
Yes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This based on the work done here
related: #569
I didn't mark this pr as closing the above issue, because one of the user acceptance criteria is that this domain is used at https://github.com/jvalue/SWC2-JValue-OCDE-Case1, which can only be fulfilled after this is merged