Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback to get PF Name for AuxNetDevice #526

Merged

Conversation

adrianchiris
Copy link
Contributor

In case we fail to get Uplink Representor, fallback to get PF PCI address and use sysfs to get PF netdevice.

This is needed in case a device supports the creation of Auxiliary devices but is not in switchdev.

In case we fail to get Uplink Representor, fallback
to get PF PCI address and use sysfs to get PF netdevice.

This is needed in case a device supports the creation of
Auxiliary devices but is not in switchdev.

Signed-off-by: adrianc <[email protected]>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7628305527

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 75.708%

Totals Coverage Status
Change from base Build 7377056051: 0.08%
Covered Lines: 2032
Relevant Lines: 2684

💛 - Coveralls

@adrianchiris
Copy link
Contributor Author

adrianchiris commented Jan 25, 2024

@Eoghan1232 PTAL if you have some time. :)

@adrianchiris
Copy link
Contributor Author

/retest

Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine to me, nice to have some backups in place :)

@adrianchiris
Copy link
Contributor Author

CI issue not related to PR.

I have tested this one in my cluster. works well.

@adrianchiris adrianchiris merged commit 32b8ca7 into k8snetworkplumbingwg:master Jan 25, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants