Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run ./build-docker.sh again before pushing karate images to registry #2574

Closed
wants to merge 1 commit into from
Closed

run ./build-docker.sh again before pushing karate images to registry #2574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/maven-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ jobs:
- name: docker push
if: ( github.event.inputs.docker == 'enabled' )
run: |
./build-docker.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daviddavidgit @jandry this is already there on line 49 so I don't think this makes a difference

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change build-docker.sh to use 2 different cache names just a thought ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let the build-docker.sh script run again because of this error:

ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref yaxwzuev1m6uf4pxk3pkre55l::rjnz27nhlipnmbx7zwlwerocm: "/target/repository": not found

I thought the runs within a step share the workspace, but does not seem the case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well the buildx runs twice but with the same "cache name". hence my comment. I'll wait until we have more clarity. again, it should be easy for anyone to set up a git project and a personal docker repo and try

docker buildx build --push --platform linux/amd64 --cache-from=type=local,src=./target/docker --cache-to=type=local,dest=./target/docker -t karatelabs/karate-chrome:${{ github.event.inputs.version }} -t karatelabs/karate-chrome:latest karate-docker/karate-chrome
docker buildx build --push --platform linux/amd64,linux/arm64 --cache-from=type=local,src=./target/docker --cache-to=type=local,dest=./target/docker -t karatelabs/karate-chromium:${{ github.event.inputs.version }} -t karatelabs/karate-chromium:latest karate-docker/karate-chromium
- name: maven deploy to central
Expand Down