Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates based on 2nd JOSS review #224

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Updates based on 2nd JOSS review #224

merged 6 commits into from
Aug 14, 2024

Conversation

karllark
Copy link
Owner

@karllark karllark commented Aug 14, 2024

The issues raised in the 2nd JOSS review (#222) are addressed here.

Developer documentation is added describing the base classes and the necessary components of each type of model. Writing this documentation motivated an update to the base classes, specifically moving the GMBase from grain_models.py to baseclasses.py and renaming it BaseExtGrainModel. This is more consistent with the structure of the package.

Small updates to the paper text based on the review.

The URL for G24 was updated to the published paper.

Closes #222.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.89%. Comparing base (010ca10) to head (2e36501).
Report is 51 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files           8        8           
  Lines         919      919           
=======================================
  Hits          918      918           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karllark karllark merged commit 670dfe0 into master Aug 14, 2024
32 checks passed
@karllark karllark deleted the joss_review2 branch August 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOSS Review: Instructions on Contributing Curves and Minor Comments
1 participant