Add SpectralUnitsWarning for more targeted warning filters #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a description to this PR to describe in words the goal. Thanks. |
Done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 8 9 +1
Lines 935 938 +3
=======================================
+ Hits 934 937 +3
Misses 1 1 ☔ View full report in Codecov by Sentry. |
karllark
requested changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for users to disable the unit conversion warnings without also suppressing other unrelated UserWarnings.
This should be a backward-compatible change: since the new warning class subclasses UserWarning, code designed to suppress UserWarnings will still suppress this warning.