Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bug on pending version acceptance #359

Merged
merged 2 commits into from
Jul 21, 2016
Merged

Conversation

meomancer
Copy link
Contributor

@meomancer meomancer commented Jul 18, 2016

here is the changes for this PR:

  • version cannot be created for pending project
  • pending version just be shown for logged in user (for the future, just for project administrator and collaborator, related with : Permissions #349)
  • pending version in project panel will redirect too pending version list view
  • when changing pending project, it will be redirect to pending project list instead detail that not found
  • make cannot access pending version listview for pending project

authenticated
screenshot from 2016-07-18 16 21 59

_not authenticated
screenshot from 2016-07-18 16 22 09

this fix #357

@rischanlab
Copy link
Contributor

Hi @meomancer could you please fixed travis failed before merge
screen shot 2016-07-19 at 9 29 39 am

Thanks.

@timlinux
Copy link
Contributor

Looks good to me! thanks @meomancer. I will merge it.

@timlinux timlinux merged commit 451cb18 into kartoza:develop Jul 21, 2016
@meomancer meomancer deleted the 357 branch July 21, 2016 09:00
dimasciput added a commit to dimasciput/projecta that referenced this pull request Apr 5, 2022
dimasciput added a commit to dimasciput/projecta that referenced this pull request Apr 5, 2022
* Fix menu (kartoza#357)

* Add custom render dashboard (kartoza#359)

* Add int and float types in csv upload (kartoza#360)

* Fix bugs in layer selector order (kartoza#363)

* Fix unsaved selected layer not displayed (kartoza#364)

* Add api to get non validated records for sidepanel validation later (kartoza#365)

* Api to get non validated records

* Add tests for unvalidated records api

* Generate permission by taxon class (kartoza#366)

* Get allowed collections based on permission (kartoza#368)

* Fix selector bugs (kartoza#370)

* Update validate records page (kartoza#371)

* Fix send email to validator (kartoza#373)

* Fix legend is covered (kartoza#375)

* Fix biodiversity legend bug (kartoza#376)

* Spatial filter (kartoza#374)

* Add spatial filter panel button

* User boundary model

* Add upload functionality in modal

* Backend for upload user boundary shapefile

* Show boundary list and add click event

* Search by user boundary

* Add boundary name input

* Select multiple boundary

* Add clear and apply filter

* Update search

* Add search mode flag

* Make marker still clickable

* Remove console log

* Update production requirements (kartoza#377)

* Fix spatial search for location site (kartoza#381)

* Fix search user_boundaries

* Fix reset search (kartoza#383)

* Add coming soon menu (kartoza#382)

* Fix spatial search if site outside boundary (kartoza#384)

* Additional filters (kartoza#385)

* Optional filters

* Fix tests

* Add new fields to collection models (kartoza#386)

* Add new fields to collection models

* Add migration file

* Add site code to location site

* Update csv upload to accomodate new fields

* Add missing migration

* Fix tests

* Fix flake8

* Fix filter not working (kartoza#387)

* Add reference category filter (kartoza#388)

* Add api to get the reference category

* Show reference category lists in filter panel

* Filter function with reference category

* Fix travis

* Fix missing variable (kartoza#389)

* Fix csv uploads (kartoza#390)

* Update location site model (kartoza#391)

* Validation ui (kartoza#392)

* Show validation list in front end

* Show point on map

* Show and hide detail

* Add validate function

* Return pagination information

* Update layout

* Fix layout

* Clear point in fetch collection

* Fix travis

* Fix side panel behavior

* Only show validate button to user who has permission

* Add compiled js

* Fix get key function (kartoza#393)

* Set search panel title in settings (kartoza#394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in version acceptance for pending project
3 participants