Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add administrator and collaborator #361

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

meomancer
Copy link
Contributor

@meomancer meomancer commented Jul 19, 2016

i am still struggling with when dbrestore, make migrate will break with error
django.db.utils.ProgrammingError: there is no unique constraint matching given keys for referenced table "base_project"

i tested it with clean db

and i don't know why travis is not building in this PR (although i already added test cases)
this partial fix #349

@meomancer
Copy link
Contributor Author

added :

  • view for list of project administrator and collaborator
  • view for add project administrator
  • view for add project collaborator
  • view for delete project administrator
  • view for delete project collaborator
  • added the test cases

UI is not final, maybe some of suggestion?

screenshots:
screenshot from 2016-07-20 16 46 21
screenshot from 2016-07-20 16 46 27
screenshot from 2016-07-20 16 46 33
screenshot from 2016-07-20 16 46 39

@timlinux
Copy link
Contributor

Do the tests pass on your local machine @meomancer ?

@meomancer meomancer force-pushed the permission branch 2 times, most recently from a0824dd to 4fbc3c9 Compare July 21, 2016 09:26
@meomancer
Copy link
Contributor Author

Add role for Project Administration and Owner

  • Now, create version, accept, delete, edit version of project is enable to it's owner and project administration
  • Assign administration and collaboration just can be done by admin and owner
  • Accepted, rejected of pending project can be don by owner and project administration
  • Visualization of "pending" project and version just show for owner and project administration

all of this role is enabled for admin

@timlinux
Copy link
Contributor

Does admin and owner also need to approve entries? It would probably make sense to do this....

Can admin and owner assign common project membership? Only project members should be able to create entries....then we can get rid of everyone being in staff group...

@meomancer
Copy link
Contributor Author

@timlinux it is not implemented for entry yet, will add this role for entry too
my question is project member just can create version and entries? and accepted by admin, owner and project admin?
could you describe me a little deep about this permission (with project members, i think) and each role?

@meomancer meomancer force-pushed the permission branch 2 times, most recently from 8f7dd09 to 5b9ffca Compare July 22, 2016 08:08
@timlinux
Copy link
Contributor

@timlinux it is not implemented for entry yet, will add this role for entry too

OK thanks!

my question is project member just can create version and entries? and accepted by admin, owner and project admin?
could you describe me a little deep about this permission (with project members, i think) and each role?

here is how I think is should work:

Organisation: We need this construct (to match github organisation construct). Can be created by any normal user who then becomes the organisation admin. We should ideally offer to create organisations based on the user's github profiles org membership. One organisation can have many projects and there should be organisation specific landing pages. I think this maps to 'owner' in your description above. Any user may be owner of one or more organisations. An organisation my have one or more owners.
Projects: created by organisation admin. Organisation admin can designate one or more users to have project admin rights. maps to project administrator in your description above. Any user can be admin to one or more projects.
Versions: Created by project admin or higher
Entries: Created by organisation members. Any user can be member of one or more organisations. Entries must be approved by a project admin or higher.

Does that make sense?

@timlinux
Copy link
Contributor

By the way we already have a team construct in project for voting etc but I think they should be organisation owned, not project owned. In an organisation you should be able to have one or more teams. e.g. documentation team, translation team, developer team, governance team, promotion team, ux team. We should add these as defaults for any new organisation, plus let the org owner create additional teams as needed.

@dimasciput
Copy link
Member

@sumandari can you check this PR and whether we should continue or just close this PR if it's not relevant anymore.

@sumandari
Copy link
Collaborator

@dimasciput the reference ticket has been closed.
but this feature has not been implemented yet on the develop branch.
I'm not sure whether we should continue in this condition. Would you please give a suggestion @dimasciput?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permissions
4 participants