Added Program hash changed event

[Akashneelesh]

• issue [feat] ProgramHashChanged Event #6
• follows contribution guide
• code change includes tests
• breaking change

Implemented the event (ProgramHashChanged) for the function set_program_info

[glihm]

hey man, thanks for that! Stacked on #12 right?

[glihm]

As in this contract the program info contains both the config hash and the program hash (as design that may be challenged @drspacemn if we should be more like solidity version), we should have a new event.

Something like:

struct ProgramInfoChanged {
    changed_by: ContractAddress,
    old_program_hash: ...,
    new_program_hash: ...,
    old_config_hash: ...,
    new_config_hash: ...,
}

WDYT guys @Akashneelesh @drspacemn @b-j-roberts?

[Akashneelesh]

Yep true, it will have both the program_hash and config_hash

[b-j-roberts]

I'd say either create a ProgramInfoChanged event or add the ConfigHashChanged event like Solidity and emit both events instead. Up to you.

[Akashneelesh]

Okay I'll just change it into ProgramInfoChanged and commit it now

[Akashneelesh]

hey man, thanks for that! Stacked on #12 right?

Yess ser

[b-j-roberts]

Our current style is to not import functions like this, instead when you use the function do Starknet::get_caller_address

[Akashneelesh]

Actually this is how its been done in other projects as well,

use starknet::{ContractAddress, get_caller_address};

I feel this is like a best practices thing, instead if we have another instance we dont need to do

Starknet::get_caller_address

Rather just call get_caller_address

[b-j-roberts]

I'd say either create a ProgramInfoChanged event or add the ConfigHashChanged event like Solidity and emit both events instead. Up to you.