add snforge to dev-dependency #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update scarb and oz version
add lib target
glihm
requested changes
Jul 11, 2024
|
Sure, let me get back on this |
- fixed oz visibility - updated sn_forge version due to failing compilation from sierra to casm(to consume USC output)
|
- Failing to deploy contracts with older version
|
Hey @glihm, please do check this as well !! |
glihm
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Thank you a lot @byteZorvin for the initial push on the version. 🚀
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One could not add piltover as a dependency due to conflicting dependency of sn_forge, if they are on a later version.
This can be solved by adding sn_forge as a dev-dependency and not dependency