Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alertID when alert not found #67

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Remove alertID when alert not found #67

merged 2 commits into from
Jul 22, 2024

Conversation

carlyjiang
Copy link
Contributor

close

Could you share the solution in high level?

  • If user manually deletes alert in wavefront, alert-manager will fall into infinite reconcile as it couldn't find missing alert.
    • If wavefront return 404, will remove alert-id from alertsconfig status, and then requeue the event.
    • In following retry cycle, alert-manager will find the alert doesn't have alert-id, will try to create new one.

Could you share the test results?

  • Create testing case that server return 404
    • Create alert thru alert-manager.
    • Delete alert thru wavefront dashboard.
    • Restart alert-manager, alert-manager will complain 404 error on deleted alert. remove alert-id from alert-status.
    • After retry the event, alert-manager is able to re-create alert again.

@carlyjiang carlyjiang requested a review from a team as a code owner July 22, 2024 05:01
@carlyjiang carlyjiang merged commit 3429c10 into master Jul 22, 2024
2 checks passed
@carlyjiang carlyjiang deleted the reset branch July 22, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants