Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed tweet style from grid to carousel #68

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

ab7022
Copy link

@ab7022 ab7022 commented Nov 30, 2024

changed testimonial style from grid to carousel

Hello Keploy team @Hermione2408 @khareyash05,
i have changed testimonial style from grid to carousel for the blog page

scrnli_cPnufRdx1JKOy8.webm

this PR closes: keploy/keploy#2437

components/Marquee.tsx Outdated Show resolved Hide resolved
components/testimonials.tsx Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
pages/index.tsx Outdated Show resolved Hide resolved
Copy link
Author

@ab7022 ab7022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lemme know if more explanation is needed or i can also write this code without custom cn function but it will make the code less readable when applying styles based on conditions.

@ab7022 ab7022 force-pushed the main branch 3 times, most recently from 235984a to 79fede5 Compare December 4, 2024 19:44
Signed-off-by: ab7022 <[email protected]>
@ab7022
Copy link
Author

ab7022 commented Dec 8, 2024

Hello @Hermione2408 ,
can you please revier it now?

@Hermione2408
Copy link
Member

Hey @ab7022 ,
Thanks for clarifying! Adding clsx seems unnecessary since we can achieve the same result with existing logic or utilities. Let’s remove it to keep things clean and avoid adding extra dependencies.
Also while doing the changes please sign off the DCO too!

@ab7022 ab7022 force-pushed the main branch 2 times, most recently from 666f667 to e7aae57 Compare December 19, 2024 13:29
Sonichigo and others added 9 commits December 19, 2024 19:05
Signed-off-by: Animesh Pathak <[email protected]>
Signed-off-by: Animesh Pathak <[email protected]>
Signed-off-by: Aditya-eddy <[email protected]>
Co-authored-by: Animesh Pathak <[email protected]>
* chore: optimize queries for specific user

Signed-off-by: Yash Khare <[email protected]>

* handle null exception

Signed-off-by: Yash Khare <[email protected]>

---------

Signed-off-by: Yash Khare <[email protected]>
Co-authored-by: Animesh Pathak <[email protected]>
Co-authored-by: Tvisha Raji <[email protected]>
…Issues

fix: Implement Pagination for API Queries to Resolve Large Data Load Issues
Signed-off-by: Abdul Bayees <[email protected]>
Signed-off-by: Abdul Bayees <[email protected]>
@ab7022
Copy link
Author

ab7022 commented Dec 19, 2024

Hello @Hermione2408 ,
i have removed clsx logic from code and dependency,
please can you review it now?
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Add Tweet Carousel instead of grid
7 participants