Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[khmer_test] new Khmer LDML keyboard #3273

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

Nnyny
Copy link
Contributor

@Nnyny Nnyny commented Jan 9, 2025

No description provided.

@Nnyny Nnyny marked this pull request as draft January 9, 2025 09:00
@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

PLEASE NOTE: team capacity for review is limited in December 2024 and will resume in January 2025. We appreciate your patience.

<!-- @@Case #1: when a subscript is typed after a vowel, the subscript should be automatically moved to before the vowel. -->
<transform from="($[v_combo_N]\u{17C6})(\u{17D2}$[subcons])" to="$2$1" /> <!-- two-part vowels have to come after a subscript -->
<transform from="($[v_combo_R])\u{17C7}\u{17D2}($[subcons])" to="\u{17D2}$2$1\u{17C7}" /> <!-- two-part vowels have to come after a subscript -->
<transform from="($[v_any])(\u{17D2}$[subcons])" to="$2$1" /> <!-- a vowel has to come after a subscript -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @srl295! I would like to report the issue with the order of transform rule as I mentioned last time. Please take a look at the rule on line 374. It's currently below the rule of line 372 and 373. However, if I wanted to move the rule 374 and place it above rule 372 instead, the transform rule suddenly won't work.

	<transform from="($[v_any])(\u{17D2}$[subcons])" to="$2$1" />
	<transform from="($[v_combo_N]\u{17C6})(\u{17D2}$[subcons])" to="$2$1" />
        <transform from="($[v_combo_R])\u{17C7}\u{17D2}($[subcons])" to="\u{17D2}$2$1\u{17C7}" />

It will give the wrong result of the normalization. Do you know why is this happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants