-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the properties table #530
Conversation
Updated the properties table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments.
@@ -510,7 +510,7 @@ KB_org_killbill_billing_server_event_post_type_skip |List of event types to be | |||
KB_org_killbill_billing_server_event_dispatch_type_skip |List of event types to be skipped (not dispatched internally) |- |Per-Tenant/Config File/Environment Variable | |||
|org.killbill.billing.server.event.bulk.subscription.aggregate/ | |||
|
|||
KB_org_killbill_billing_server_event_bulk_subscription_aggregate |Coming Soon |false |Per-Tenant/Config File/Environment Variable | |||
KB_org_killbill_billing_server_event_bulk_subscription_aggregate |Aggregate the events for bulk subscription |false |Per-Tenant/Config File/Environment Variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe create a PR to also update it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Reshma, Here it is : killbill/killbill#1936
@@ -976,7 +976,7 @@ KB_org_killbill_security_skipAuthForPlugins |Specifies whether authentication | |||
|=== | |||
|Property Name/Environment Variable Name |Description |Default Value | Configuration Method | |||
//------------------------------------------------- | |||
|org.killbill.catalog.frequentValuesCacheSize |Coming Soon |1000 |System property | |||
|org.killbill.catalog.frequentValuesCacheSize |Number of values to be considered for cache |1000 |System property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is used in the DefaultPrice class. So, maybe specify that it is applicable for price and elaborate it slightly? The logic for this is here.
|kaui.read_timeout/ | ||
|
||
KILLBILL_READ_TIMEOUT/ | ||
|
||
KAUI_KILLBILL_READ_TIMEOUT |Coming Soon |60000 | ||
KAUI_KILLBILL_READ_TIMEOUT |Specifies the read timeout |60000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the specify the time after which Kaui times out if it is unable to connect to KB? If so, could you elaborate this?
|kaui.connection_timeout/ | ||
|
||
KILLBILL_CONNECTION_TIMEOUT/ | ||
|
||
KAUI_KILLBILL_CONNECTION_TIMEOUT |Coming Soon |60000 | ||
KAUI_KILLBILL_CONNECTION_TIMEOUT |Specifies the connection timeout |60000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above, we need to confirm if this is the KB connection timeout and if so elaborate this description
|kaui.plugins_whitelist/ | ||
|
||
KAUI_PLUGINS_WHITELIST |Coming Soon |None | ||
KAUI_PLUGINS_WHITELIST |Kaui plugins to be whitelisted |None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit unclear to me. Maybe check with Kyle and elaborate this a bit?
Support for OpenJDK added to docs
@@ -20,7 +20,7 @@ The first step in installing Kill Bill in Tomcat is to download and install Tomc | |||
|
|||
|
|||
|
|||
. Ensure that you have *JDK 11* installed (It can be downloaded from https://www.oracle.com/in/java/technologies/javase/jdk11-archive-downloads.html[here]) | |||
. Ensure that you have *JDK 11* installed ( https://www.openlogic.com/openjdk-downloads[OpenJDK] is the default requirement, though Kill Bill supports all JDKs. Oracle JDK can be downloaded from https://www.oracle.com/in/java/technologies/javase/jdk11-archive-downloads.html[here]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://openjdk.org/ is the official OpenJDK website
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also include some text to say that all JVMs are supported as mentioned by Stephane on slack?
Updated the properties table