Downgrade platform requirement and link frameworks #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi2gage
force-pushed
the
reduce_platform_and_link_frameworks
branch
from
81fe5d4 to
a495c67
Compare
hi2gage
commented
Oct 18, 2024
| @@ -4,8 +4,7 @@ | |||
| version = "1.8"> | |||
| <BuildAction | |||
| parallelizeBuildables = "YES" | |||
| buildImplicitDependencies = "YES" | |||
There was a problem hiding this comment.
This is more of an annoyance thing. With this set to automatic the version = "1.8" will switch back and other across machines.
hi2gage
commented
Oct 18, 2024
| @@ -5,7 +5,7 @@ import PackageDescription | |||
|
|
|||
| let package = Package( | |||
| name: "LibFido2Swift", | |||
| platforms: [.macOS(.v13)], | |||
| platforms: [.macOS(.v10_15)], | |||
There was a problem hiding this comment.
Keeping this at minimum possible value is usually best for adoption
hi2gage
commented
Oct 18, 2024
| @@ -18,7 +18,12 @@ let package = Package( | |||
| .target( | |||
| name: "LibFido2Swift", | |||
| dependencies: ["LibCrypto", "libfido2", "LibCbor"], | |||
| path: "LibFido2Swift" | |||
| path: "LibFido2Swift", | |||
| linkerSettings: [ | |||
hi2gage
force-pushed
the
reduce_platform_and_link_frameworks
branch
from
a495c67 to
79c1dd5
Compare
hi2gage
force-pushed
the
reduce_platform_and_link_frameworks
branch
from
79c1dd5 to
ac05b0c
Compare
hi2gage
force-pushed
the
reduce_platform_and_link_frameworks
branch
6 times, most recently
from
ae8d7eb to
91327db
Compare
|
Thanks for this! Good idea on the GitHub releases I can get that set up. And just lmk whenever this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔️Don't merge this yet. I don't know it actually solved my problem.⛔️
I'm having serious issues linking this package to another Swift Package which doesn't make sense to me.
Part 1 of implementing Implement Security Key Auth into xcodes CLI tool.
Reference: XcodesOrg/XcodesApp#617
Since the CLI tool is a swift package and not an Xcode project we need to Explicitly link these binary dependencies to your library. This allows the linker down stream to work correctly.
Let me know if you have any questions. Also if this is going to be a "true" dependency it would be great to get releases setup on GitHub so we don't reference commit hashes.