Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retevis h777h #1227

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Add retevis h777h #1227

merged 2 commits into from
Jan 13, 2025

Conversation

KC9HI
Copy link
Contributor

@KC9HI KC9HI commented Jan 13, 2025

CHIRP PR Guidelines

The following must be true before PRs can be merged:

  1. All tests must be passing. The "PR Checks" job is speculative and failure doesn't always indicate a critial problem, but generally it needs to pass as well.
  2. Commits should be rebased (or simply rebase-able in the web UI) on current master. Do not put merge commits in a PR.
  3. Commits in a single PR should be related. Squash intermediate commits into logical units (i.e. "fix tests" commits need not survive on their own). Keep cleanup commits separate from functional changes.
  4. Major new features or bug fixes should reference a CHIRP issue in the commit message. Do this with the pattern Fixes #1234 or Related to #1234 so that the ticket system links the commit to the issue.
  5. Please write a reasonable commit message, especially if making some change that isn't totally obvious (such as adding a new model, adding a feature, etc). The first line of every commit is emailed to the users' list after each build. It should be short, but meaningful for regular users (examples: "thd74: Fixed tone decoding" or "uv5r: Added settings support").
  6. New drivers should be accompanied by a test image in tests/images (except for thin aliases where the driver is sufficiently tested already). All new drivers must use MemoryMapBytes.
  7. All files must be GPLv3 licensed or contain no license verbiage. No additional restrictions can be placed on the usage (i.e. such as noncommercial).
  8. Do not add new py2-compatibility code (No new uses of six, future, etc).

@kk7ds
Copy link
Owner

kk7ds commented Jan 13, 2025

Oh, hey, I wasn't paying attention when you mentioned this. But, as of a few months ago, we don't have to maintain py3_driver_testers.txt. Since the tested ones far outnumber the untested ones, we now just track the untested ones in py3_untested_drivers.txt (removed from the PR instructions above). I kept the former just for the record, although I should make a note at the top that it's no longer required.

By, no harm to add them anyway :)

@kk7ds kk7ds force-pushed the add-retevis-h777h branch from 7074d69 to a1591e9 Compare January 13, 2025 05:04
@kk7ds kk7ds merged commit a7b805a into kk7ds:master Jan 13, 2025
6 checks passed
@KC9HI
Copy link
Contributor Author

KC9HI commented Jan 13, 2025

Nice! That must be why I didn't see a couple of other files updated as a result of executing makesupported. I was worried that I might have missed a step. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants