Tdh8 duplex adds off option #789
Conversation
| @@ -1018,6 +1021,8 @@ def set_memory(self, mem): | |||
| _mem.txfreq = (mem.freq + mem.offset) / 10 | |||
| elif mem.duplex == "-": | |||
| _mem.txfreq = (mem.freq - mem.offset) / 10 | |||
| elif mem.duplex == 'off': | |||
| _mem.txfreq = 166666665 | |||
There was a problem hiding this comment.
This value is larger than can be stored in the field, so it gets truncated. It also looks like an overflow value. What does the radio really want here? 0? 0xFFFF?
|
This should say "Related bug #10756" in the commit message to tag this to that open issue. That issue proposes 0xFF for each byte, and that would be much cleaner than what you have here. If that's suitable, please change to use that. You might also implement the mic gain as requested in that issue (and may be fixed in the same file too). As you see from the failed check, you need to rebase your set on master, not include the merge commits. Thanks! |
Related to bug #10756
|
I rebased this for you and tagged the bug. If the right thing to do is use 0xFF for the sentinels, please submit another PR (or confirm and I'll do it). |
Tdh8 duplex adds off option