Two bug fixes and cleanup #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kk7ds
commented
Oct 30, 2023
kk7ds
commented
- uvk5: Fix invalid return when firmware probe fails
- th9000: Fix program mode negotiation
- Fix bitwise grammar for bitfield
This needs to raise an exception instead of returning a boolean, as the latter just causes failures later trying to treat the boolean as a memmap object. Related to bug 10921
This makes us break out of the loop once we have received a positive response to program mode. Fixes #10922
Long ago, an error in the bitwise grammar allowed bitfields to be defined without the comma delimiter between fields. This fixes that error to make the grammar correct and also fixes the *many* errors in bitwise definitions in a lot of drivers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.