Test updates #801
Merged
Test updates #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kk7ds
force-pushed
the
special-empty-test
branch
2 times, most recently
from
b098255 to
7b16f01
Compare
This test may have gotten an empty special channel before it makes the edit. Set it to non-empty when making the edit like it would be in reality.
These radios were massively slowing down the tests because of how laborious the yaesu bank model is to survey. They should be cached anyway.
Fixes: #10930
Also adds a test for this which shook out several offenders and a few mem.extra bugs, which are also fixed here.
kk7ds
force-pushed
the
special-empty-test
branch
from
7b16f01 to
e1ac3ca
Compare
This method should not be implemented by new drivers, so fail the check if it looks like it is present.
This must be a list (or RadioSettingGroup) of RadioSetting objects.
This is not to allow excluding drivers from tests, but rather to allow for iterating towards fixes for specific issues. Do not add new lines to this file without justification.
This makes us include the *structure* of mem.extra in the assertEqualMems() check to make sure it doesn't change before and after a modification.
kk7ds
force-pushed
the
special-empty-test
branch
from
e1ac3ca to
6b2a5bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test may have gotten an empty special channel before it makes
the edit. Set it to non-empty when making the edit like it would be
in reality.