forked from Automattic/simplenote-ios
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] trunk from Automattic:trunk #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes should have been done via PR, see #1621 Revert "Fix incorrect config file path" This reverts commit 5f8b66a. Revert "Update Fastlane versioning object to reflect app's strategy" This reverts commit 9f96265. Revert "DRY workspace definition" This reverts commit ffbe630. Revert "Use project file as source of truth for ASC code signing settings" This reverts commit c704b27. Revert "Extract logic to build for ASC in dedicated lane" This reverts commit 4a244ca. Revert "Use `xcconfig` to specify provisioning profile for ASC builds" This reverts commit 447ec15. Revert "Use `xcconfig` to define development team for release builds" This reverts commit 3ca756a. Revert "Remove `ios_build_preflight` and `ios_build_prechecks` from build lane" This reverts commit 66781d6 Revert "Remove calls to delete artifacts from build for ASC lane" This reverts commit 14149e9. Revert "Use named block arguments in build for ASC lane" This reverts commit 96639bf. Revert "Extract lane to build for ASC into dedicated file" This reverts commit 883781d. Revert "Double quote a var access in `release-build.sh`" This reverts commit 96aa4d2. Revert "Merge remote-tracking branch 'origin/trunk' into mokagio/release-automation-update" This reverts commit 98c3b93, reversing changes made to 009cbdb. Revert "Remove unnecessary comments and double quotes from Buildkite pipelines" This reverts commit 009cbdb. Revert "Add shared vars and explicitly set agents in Buildkite pipelines" This reverts commit 63a16fc. Revert "Move method to trigger Buildkite release build to `release.rb`" This reverts commit 754d277. Revert "DRY one release branch name computation" This reverts commit 2909545. Revert "Add command to check CocoaPods are using stable versions" This reverts commit f390b27. Revert "Update release-toolkit to latest version" This reverts commit 9e757f4. Revert "Introduce version calculators and adopt in code freeze lane" This reverts commit 22c766f. Revert "Use `skip_confirm:` named argument in code freeze lane" This reverts commit 5994d4e. Revert "Replace `ios_codefreeze_prechecks` with individual checks" This reverts commit 7ab3092. Revert "Remove `project.env` from `configure`" This reverts commit 03f66af. Revert "Replace unnecessarily reads from env of team ids with direct definition" This reverts commit 6676dea. Revert "Remove obsolete lane to register device" This reverts commit 5f29398. Revert "Introduce `EnvManager`" This reverts commit c6d14fa. Revert "Use `set_milestone_frozen_marker` instead of `setfrozentag`" This reverts commit 624c158. Revert "Move `new_beta` lane to `release.rb`" This reverts commit d70669a. Revert "Move code freeze lane to dedicated file" This reverts commit 6c22956. Revert "Move lane to generate strings to dedicated file" This reverts commit 95bb7e6.
I accidentally pushed commits to `trunk` which should have been in a PR while experimenting with an updated code freeze workflow for version 4.52. This commit was done by comparing against the tip of `trunk` before my mistake, f85f732 It reverts bfc2fc0 and a774214, then cherry-picks all those changes there were somehow reverted in my previous fix attempt, eb52ef6
Co-authored-by: Olivier Halligon <[email protected]>
Co-authored-by: Ian Guedes Maia <[email protected]>
We no longer need repo-level automation to trigger release lanes. See #1655 (comment)
Co-authored-by: Ian Guedes Maia <[email protected]>
Follow up to e48732f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )