libkmod: Fix ELFDBG usage #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelikov
approved these changes
Sep 23, 2024
|
I think that it would make sense to integrate the ELFDBG usage into DBG, so it also takes the log function as specified in context. Not sure why they should be handled so differently compared to other debug messages. |
|
My feeling was that Looking around distros some use |
The first parameter has to be a kmod_elf. Signed-off-by: Tobias Stoeckmann <[email protected]>
Signed-off-by: Tobias Stoeckmann <[email protected]>
lucasdemarchi
pushed a commit
that referenced
this pull request
Sep 28, 2024
The first parameter has to be a kmod_elf. Signed-off-by: Tobias Stoeckmann <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #148 Signed-off-by: Lucas De Marchi <[email protected]>
lucasdemarchi
pushed a commit
that referenced
this pull request
Sep 28, 2024
Signed-off-by: Tobias Stoeckmann <[email protected]> Reviewed-by: Emil Velikov <[email protected]> Link: #148 Signed-off-by: Lucas De Marchi <[email protected]>
|
Applied, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If debug is enabled through macro
ENABLE_ELFDBGin libkmod-elf.c, compilation fails because two callers use wrong arguments.While at it, fixed a typo.