Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libkmod: Plug memory leak on error path #153

Closed
wants to merge 1 commit into from
Closed

libkmod: Plug memory leak on error path #153

wants to merge 1 commit into from

Conversation

stoeckmann
Copy link
Contributor

Fix memory leak on error path introduced with read_u32 error checks.

Leak introduced with: 9d965d3

@stoeckmann
libkmod: Plug memory leak on error path
a5eb3c1 
Fix memory leak on error path introduced with read_u32 error checks.

Signed-off-by: Tobias Stoeckmann <[email protected]>
evelikov
evelikov approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@evelikov evelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the sanitizer issues fixed, I think we can override the ASAN variable (to silence the link order messages) and enable it. Do you want to do it, or shall I?

For this patch itself, it look good. Thanks

@stoeckmann
Copy link
Contributor Author

With the sanitizer issues fixed, I think we can override the ASAN variable (to silence the link order messages) and enable it. Do you want to do it, or shall I?

You can do it, although I would like to know why the ordering is off. Haven't been into this issue yet.

lucasdemarchi pushed a commit that referenced this pull request Sep 28, 2024
@stoeckmann @lucasdemarchi
libkmod: Plug memory leak on error path
f996293 
Fix memory leak on error path introduced with read_u32 error checks.

Signed-off-by: Tobias Stoeckmann <[email protected]>
Reviewed-by: Emil Velikov <[email protected]>
Link: #153
Signed-off-by: Lucas De Marchi <[email protected]>
@lucasdemarchi
Copy link
Contributor

Applied, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evelikov evelikov evelikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stoeckmann @lucasdemarchi @evelikov