Fixing all deprecated use of sets.String #2367
matzewknative-verify.yaml
on: pull_request
verify
/
Verify Deps and Codegen
2m 41s
Annotations
10 errors and 1 warning
|
verify / Verify Deps and Codegen:
client/injection/apiextensions/reconciler/apiextensions/v1/customresourcedefinition/reconciler.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/client/injection/apiextensions/reconciler/apiextensions/v1/customresourcedefinition/reconciler.go b/client/injection/apiextensions/reconciler/apiextensions/v1/customresourcedefinition/reconciler.go
index 0e73b5f..ffc2b02 100644
--- a/client/injection/apiextensions/reconciler/apiextensions/v1/customresourcedefinition/reconciler.go
+++ b/client/injection/apiextensions/reconciler/apiextensions/v1/customresourcedefinition/reconciler.go
@@ -338,14 +338,14 @@ func (r *reconcilerImpl) updateStatus(ctx context.Context, logger *zap.SugaredLo
// updateFinalizersFiltered will update the Finalizers of the resource.
// TODO: this method could be generic and sync all finalizers. For now it only
// updates defaultFinalizerName or its override.
-func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1.CustomResourceDefinition, desiredFinalizers sets.Set[string]) (*v1.CustomResourceDefinition, error) {
+func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1.CustomResourceDefinition, desiredFinalizers sets.String) (*v1.CustomResourceDefinition, error) {
// Don't modify the informers copy.
existing := resource.DeepCopy()
var finalizers []string
// If there's nothing to update, just return.
- existingFinalizers := sets.New[string](existing.Finalizers...)
+ existingFinalizers := sets.NewString(existing.Finalizers...)
if desiredFinalizers.Has(r.finalizerName) {
if existingFinalizers.Has(r.finalizerName) {
@@ -361,7 +361,7 @@ func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource
}
// Remove the finalizer.
existingFinalizers.Delete(r.finalizerName)
- finalizers = sets.List(existingFinalizers)
+ finalizers = existingFinalizers.List()
}
mergePatch := map[string]interface{}{
@@ -395,7 +395,7 @@ func (r *reconcilerImpl) setFinalizerIfFinalizer(ctx context.Context, resource *
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
// If this resource is not being deleted, mark the finalizer.
if resource.GetDeletionTimestamp().IsZero() {
@@ -414,7 +414,7 @@ func (r *reconcilerImpl) clearFinalizer(ctx context.Context, resource *v1.Custom
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
if reconcileEvent != nil {
var event *reconciler.ReconcilerEvent
|
|
verify / Verify Deps and Codegen:
client/injection/apiextensions/reconciler/apiextensions/v1beta1/customresourcedefinition/reconciler.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/client/injection/apiextensions/reconciler/apiextensions/v1beta1/customresourcedefinition/reconciler.go b/client/injection/apiextensions/reconciler/apiextensions/v1beta1/customresourcedefinition/reconciler.go
index 1c5f6c1..c68f5f3 100644
--- a/client/injection/apiextensions/reconciler/apiextensions/v1beta1/customresourcedefinition/reconciler.go
+++ b/client/injection/apiextensions/reconciler/apiextensions/v1beta1/customresourcedefinition/reconciler.go
@@ -338,14 +338,14 @@ func (r *reconcilerImpl) updateStatus(ctx context.Context, logger *zap.SugaredLo
// updateFinalizersFiltered will update the Finalizers of the resource.
// TODO: this method could be generic and sync all finalizers. For now it only
// updates defaultFinalizerName or its override.
-func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1beta1.CustomResourceDefinition, desiredFinalizers sets.Set[string]) (*v1beta1.CustomResourceDefinition, error) {
+func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1beta1.CustomResourceDefinition, desiredFinalizers sets.String) (*v1beta1.CustomResourceDefinition, error) {
// Don't modify the informers copy.
existing := resource.DeepCopy()
var finalizers []string
// If there's nothing to update, just return.
- existingFinalizers := sets.New[string](existing.Finalizers...)
+ existingFinalizers := sets.NewString(existing.Finalizers...)
if desiredFinalizers.Has(r.finalizerName) {
if existingFinalizers.Has(r.finalizerName) {
@@ -361,7 +361,7 @@ func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource
}
// Remove the finalizer.
existingFinalizers.Delete(r.finalizerName)
- finalizers = sets.List(existingFinalizers)
+ finalizers = existingFinalizers.List()
}
mergePatch := map[string]interface{}{
@@ -395,7 +395,7 @@ func (r *reconcilerImpl) setFinalizerIfFinalizer(ctx context.Context, resource *
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
// If this resource is not being deleted, mark the finalizer.
if resource.GetDeletionTimestamp().IsZero() {
@@ -414,7 +414,7 @@ func (r *reconcilerImpl) clearFinalizer(ctx context.Context, resource *v1beta1.C
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
if reconcileEvent != nil {
var event *reconciler.ReconcilerEvent
|
|
verify / Verify Deps and Codegen:
client/injection/kube/reconciler/admissionregistration/v1/mutatingwebhookconfiguration/reconciler.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/client/injection/kube/reconciler/admissionregistration/v1/mutatingwebhookconfiguration/reconciler.go b/client/injection/kube/reconciler/admissionregistration/v1/mutatingwebhookconfiguration/reconciler.go
index 215dc90..136d073 100644
--- a/client/injection/kube/reconciler/admissionregistration/v1/mutatingwebhookconfiguration/reconciler.go
+++ b/client/injection/kube/reconciler/admissionregistration/v1/mutatingwebhookconfiguration/reconciler.go
@@ -271,14 +271,14 @@ func (r *reconcilerImpl) Reconcile(ctx context.Context, key string) error {
// updateFinalizersFiltered will update the Finalizers of the resource.
// TODO: this method could be generic and sync all finalizers. For now it only
// updates defaultFinalizerName or its override.
-func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1.MutatingWebhookConfiguration, desiredFinalizers sets.Set[string]) (*v1.MutatingWebhookConfiguration, error) {
+func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1.MutatingWebhookConfiguration, desiredFinalizers sets.String) (*v1.MutatingWebhookConfiguration, error) {
// Don't modify the informers copy.
existing := resource.DeepCopy()
var finalizers []string
// If there's nothing to update, just return.
- existingFinalizers := sets.New[string](existing.Finalizers...)
+ existingFinalizers := sets.NewString(existing.Finalizers...)
if desiredFinalizers.Has(r.finalizerName) {
if existingFinalizers.Has(r.finalizerName) {
@@ -294,7 +294,7 @@ func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource
}
// Remove the finalizer.
existingFinalizers.Delete(r.finalizerName)
- finalizers = sets.List(existingFinalizers)
+ finalizers = existingFinalizers.List()
}
mergePatch := map[string]interface{}{
@@ -328,7 +328,7 @@ func (r *reconcilerImpl) setFinalizerIfFinalizer(ctx context.Context, resource *
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
// If this resource is not being deleted, mark the finalizer.
if resource.GetDeletionTimestamp().IsZero() {
@@ -347,7 +347,7 @@ func (r *reconcilerImpl) clearFinalizer(ctx context.Context, resource *v1.Mutati
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
if reconcileEvent != nil {
var event *reconciler.ReconcilerEvent
|
|
verify / Verify Deps and Codegen:
client/injection/kube/reconciler/admissionregistration/v1/validatingwebhookconfiguration/reconciler.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/client/injection/kube/reconciler/admissionregistration/v1/validatingwebhookconfiguration/reconciler.go b/client/injection/kube/reconciler/admissionregistration/v1/validatingwebhookconfiguration/reconciler.go
index 6ebc844..b3ac24f 100644
--- a/client/injection/kube/reconciler/admissionregistration/v1/validatingwebhookconfiguration/reconciler.go
+++ b/client/injection/kube/reconciler/admissionregistration/v1/validatingwebhookconfiguration/reconciler.go
@@ -271,14 +271,14 @@ func (r *reconcilerImpl) Reconcile(ctx context.Context, key string) error {
// updateFinalizersFiltered will update the Finalizers of the resource.
// TODO: this method could be generic and sync all finalizers. For now it only
// updates defaultFinalizerName or its override.
-func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1.ValidatingWebhookConfiguration, desiredFinalizers sets.Set[string]) (*v1.ValidatingWebhookConfiguration, error) {
+func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1.ValidatingWebhookConfiguration, desiredFinalizers sets.String) (*v1.ValidatingWebhookConfiguration, error) {
// Don't modify the informers copy.
existing := resource.DeepCopy()
var finalizers []string
// If there's nothing to update, just return.
- existingFinalizers := sets.New[string](existing.Finalizers...)
+ existingFinalizers := sets.NewString(existing.Finalizers...)
if desiredFinalizers.Has(r.finalizerName) {
if existingFinalizers.Has(r.finalizerName) {
@@ -294,7 +294,7 @@ func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource
}
// Remove the finalizer.
existingFinalizers.Delete(r.finalizerName)
- finalizers = sets.List(existingFinalizers)
+ finalizers = existingFinalizers.List()
}
mergePatch := map[string]interface{}{
@@ -328,7 +328,7 @@ func (r *reconcilerImpl) setFinalizerIfFinalizer(ctx context.Context, resource *
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
// If this resource is not being deleted, mark the finalizer.
if resource.GetDeletionTimestamp().IsZero() {
@@ -347,7 +347,7 @@ func (r *reconcilerImpl) clearFinalizer(ctx context.Context, resource *v1.Valida
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
if reconcileEvent != nil {
var event *reconciler.ReconcilerEvent
|
|
verify / Verify Deps and Codegen:
client/injection/kube/reconciler/admissionregistration/v1beta1/mutatingwebhookconfiguration/reconciler.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/client/injection/kube/reconciler/admissionregistration/v1beta1/mutatingwebhookconfiguration/reconciler.go b/client/injection/kube/reconciler/admissionregistration/v1beta1/mutatingwebhookconfiguration/reconciler.go
index c8ebd21..df0ae45 100644
--- a/client/injection/kube/reconciler/admissionregistration/v1beta1/mutatingwebhookconfiguration/reconciler.go
+++ b/client/injection/kube/reconciler/admissionregistration/v1beta1/mutatingwebhookconfiguration/reconciler.go
@@ -271,14 +271,14 @@ func (r *reconcilerImpl) Reconcile(ctx context.Context, key string) error {
// updateFinalizersFiltered will update the Finalizers of the resource.
// TODO: this method could be generic and sync all finalizers. For now it only
// updates defaultFinalizerName or its override.
-func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1beta1.MutatingWebhookConfiguration, desiredFinalizers sets.Set[string]) (*v1beta1.MutatingWebhookConfiguration, error) {
+func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1beta1.MutatingWebhookConfiguration, desiredFinalizers sets.String) (*v1beta1.MutatingWebhookConfiguration, error) {
// Don't modify the informers copy.
existing := resource.DeepCopy()
var finalizers []string
// If there's nothing to update, just return.
- existingFinalizers := sets.New[string](existing.Finalizers...)
+ existingFinalizers := sets.NewString(existing.Finalizers...)
if desiredFinalizers.Has(r.finalizerName) {
if existingFinalizers.Has(r.finalizerName) {
@@ -294,7 +294,7 @@ func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource
}
// Remove the finalizer.
existingFinalizers.Delete(r.finalizerName)
- finalizers = sets.List(existingFinalizers)
+ finalizers = existingFinalizers.List()
}
mergePatch := map[string]interface{}{
@@ -328,7 +328,7 @@ func (r *reconcilerImpl) setFinalizerIfFinalizer(ctx context.Context, resource *
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
// If this resource is not being deleted, mark the finalizer.
if resource.GetDeletionTimestamp().IsZero() {
@@ -347,7 +347,7 @@ func (r *reconcilerImpl) clearFinalizer(ctx context.Context, resource *v1beta1.M
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
if reconcileEvent != nil {
var event *reconciler.ReconcilerEvent
|
|
verify / Verify Deps and Codegen:
client/injection/kube/reconciler/admissionregistration/v1beta1/validatingwebhookconfiguration/reconciler.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/client/injection/kube/reconciler/admissionregistration/v1beta1/validatingwebhookconfiguration/reconciler.go b/client/injection/kube/reconciler/admissionregistration/v1beta1/validatingwebhookconfiguration/reconciler.go
index 12d1879..c1407f2 100644
--- a/client/injection/kube/reconciler/admissionregistration/v1beta1/validatingwebhookconfiguration/reconciler.go
+++ b/client/injection/kube/reconciler/admissionregistration/v1beta1/validatingwebhookconfiguration/reconciler.go
@@ -271,14 +271,14 @@ func (r *reconcilerImpl) Reconcile(ctx context.Context, key string) error {
// updateFinalizersFiltered will update the Finalizers of the resource.
// TODO: this method could be generic and sync all finalizers. For now it only
// updates defaultFinalizerName or its override.
-func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1beta1.ValidatingWebhookConfiguration, desiredFinalizers sets.Set[string]) (*v1beta1.ValidatingWebhookConfiguration, error) {
+func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1beta1.ValidatingWebhookConfiguration, desiredFinalizers sets.String) (*v1beta1.ValidatingWebhookConfiguration, error) {
// Don't modify the informers copy.
existing := resource.DeepCopy()
var finalizers []string
// If there's nothing to update, just return.
- existingFinalizers := sets.New[string](existing.Finalizers...)
+ existingFinalizers := sets.NewString(existing.Finalizers...)
if desiredFinalizers.Has(r.finalizerName) {
if existingFinalizers.Has(r.finalizerName) {
@@ -294,7 +294,7 @@ func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource
}
// Remove the finalizer.
existingFinalizers.Delete(r.finalizerName)
- finalizers = sets.List(existingFinalizers)
+ finalizers = existingFinalizers.List()
}
mergePatch := map[string]interface{}{
@@ -328,7 +328,7 @@ func (r *reconcilerImpl) setFinalizerIfFinalizer(ctx context.Context, resource *
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
// If this resource is not being deleted, mark the finalizer.
if resource.GetDeletionTimestamp().IsZero() {
@@ -347,7 +347,7 @@ func (r *reconcilerImpl) clearFinalizer(ctx context.Context, resource *v1beta1.V
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
if reconcileEvent != nil {
var event *reconciler.ReconcilerEvent
|
|
verify / Verify Deps and Codegen:
client/injection/kube/reconciler/apps/v1/deployment/reconciler.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/client/injection/kube/reconciler/apps/v1/deployment/reconciler.go b/client/injection/kube/reconciler/apps/v1/deployment/reconciler.go
index 7241301..c24c339 100644
--- a/client/injection/kube/reconciler/apps/v1/deployment/reconciler.go
+++ b/client/injection/kube/reconciler/apps/v1/deployment/reconciler.go
@@ -338,14 +338,14 @@ func (r *reconcilerImpl) updateStatus(ctx context.Context, logger *zap.SugaredLo
// updateFinalizersFiltered will update the Finalizers of the resource.
// TODO: this method could be generic and sync all finalizers. For now it only
// updates defaultFinalizerName or its override.
-func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1.Deployment, desiredFinalizers sets.Set[string]) (*v1.Deployment, error) {
+func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1.Deployment, desiredFinalizers sets.String) (*v1.Deployment, error) {
// Don't modify the informers copy.
existing := resource.DeepCopy()
var finalizers []string
// If there's nothing to update, just return.
- existingFinalizers := sets.New[string](existing.Finalizers...)
+ existingFinalizers := sets.NewString(existing.Finalizers...)
if desiredFinalizers.Has(r.finalizerName) {
if existingFinalizers.Has(r.finalizerName) {
@@ -361,7 +361,7 @@ func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource
}
// Remove the finalizer.
existingFinalizers.Delete(r.finalizerName)
- finalizers = sets.List(existingFinalizers)
+ finalizers = existingFinalizers.List()
}
mergePatch := map[string]interface{}{
@@ -395,7 +395,7 @@ func (r *reconcilerImpl) setFinalizerIfFinalizer(ctx context.Context, resource *
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
// If this resource is not being deleted, mark the finalizer.
if resource.GetDeletionTimestamp().IsZero() {
@@ -414,7 +414,7 @@ func (r *reconcilerImpl) clearFinalizer(ctx context.Context, resource *v1.Deploy
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
if reconcileEvent != nil {
var event *reconciler.ReconcilerEvent
|
|
verify / Verify Deps and Codegen:
client/injection/kube/reconciler/apps/v1beta1/deployment/reconciler.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/client/injection/kube/reconciler/apps/v1beta1/deployment/reconciler.go b/client/injection/kube/reconciler/apps/v1beta1/deployment/reconciler.go
index 8440f87..26aaadd 100644
--- a/client/injection/kube/reconciler/apps/v1beta1/deployment/reconciler.go
+++ b/client/injection/kube/reconciler/apps/v1beta1/deployment/reconciler.go
@@ -338,14 +338,14 @@ func (r *reconcilerImpl) updateStatus(ctx context.Context, logger *zap.SugaredLo
// updateFinalizersFiltered will update the Finalizers of the resource.
// TODO: this method could be generic and sync all finalizers. For now it only
// updates defaultFinalizerName or its override.
-func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1beta1.Deployment, desiredFinalizers sets.Set[string]) (*v1beta1.Deployment, error) {
+func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1beta1.Deployment, desiredFinalizers sets.String) (*v1beta1.Deployment, error) {
// Don't modify the informers copy.
existing := resource.DeepCopy()
var finalizers []string
// If there's nothing to update, just return.
- existingFinalizers := sets.New[string](existing.Finalizers...)
+ existingFinalizers := sets.NewString(existing.Finalizers...)
if desiredFinalizers.Has(r.finalizerName) {
if existingFinalizers.Has(r.finalizerName) {
@@ -361,7 +361,7 @@ func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource
}
// Remove the finalizer.
existingFinalizers.Delete(r.finalizerName)
- finalizers = sets.List(existingFinalizers)
+ finalizers = existingFinalizers.List()
}
mergePatch := map[string]interface{}{
@@ -395,7 +395,7 @@ func (r *reconcilerImpl) setFinalizerIfFinalizer(ctx context.Context, resource *
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
// If this resource is not being deleted, mark the finalizer.
if resource.GetDeletionTimestamp().IsZero() {
@@ -414,7 +414,7 @@ func (r *reconcilerImpl) clearFinalizer(ctx context.Context, resource *v1beta1.D
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
if reconcileEvent != nil {
var event *reconciler.ReconcilerEvent
|
|
verify / Verify Deps and Codegen:
client/injection/kube/reconciler/apps/v1beta2/deployment/reconciler.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/client/injection/kube/reconciler/apps/v1beta2/deployment/reconciler.go b/client/injection/kube/reconciler/apps/v1beta2/deployment/reconciler.go
index 82a389d..bed35bb 100644
--- a/client/injection/kube/reconciler/apps/v1beta2/deployment/reconciler.go
+++ b/client/injection/kube/reconciler/apps/v1beta2/deployment/reconciler.go
@@ -338,14 +338,14 @@ func (r *reconcilerImpl) updateStatus(ctx context.Context, logger *zap.SugaredLo
// updateFinalizersFiltered will update the Finalizers of the resource.
// TODO: this method could be generic and sync all finalizers. For now it only
// updates defaultFinalizerName or its override.
-func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1beta2.Deployment, desiredFinalizers sets.Set[string]) (*v1beta2.Deployment, error) {
+func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1beta2.Deployment, desiredFinalizers sets.String) (*v1beta2.Deployment, error) {
// Don't modify the informers copy.
existing := resource.DeepCopy()
var finalizers []string
// If there's nothing to update, just return.
- existingFinalizers := sets.New[string](existing.Finalizers...)
+ existingFinalizers := sets.NewString(existing.Finalizers...)
if desiredFinalizers.Has(r.finalizerName) {
if existingFinalizers.Has(r.finalizerName) {
@@ -361,7 +361,7 @@ func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource
}
// Remove the finalizer.
existingFinalizers.Delete(r.finalizerName)
- finalizers = sets.List(existingFinalizers)
+ finalizers = existingFinalizers.List()
}
mergePatch := map[string]interface{}{
@@ -395,7 +395,7 @@ func (r *reconcilerImpl) setFinalizerIfFinalizer(ctx context.Context, resource *
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
// If this resource is not being deleted, mark the finalizer.
if resource.GetDeletionTimestamp().IsZero() {
@@ -414,7 +414,7 @@ func (r *reconcilerImpl) clearFinalizer(ctx context.Context, resource *v1beta2.D
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
if reconcileEvent != nil {
var event *reconciler.ReconcilerEvent
|
|
verify / Verify Deps and Codegen:
client/injection/kube/reconciler/batch/v1/cronjob/reconciler.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/client/injection/kube/reconciler/batch/v1/cronjob/reconciler.go b/client/injection/kube/reconciler/batch/v1/cronjob/reconciler.go
index bbafc4a..c6c2513 100644
--- a/client/injection/kube/reconciler/batch/v1/cronjob/reconciler.go
+++ b/client/injection/kube/reconciler/batch/v1/cronjob/reconciler.go
@@ -338,14 +338,14 @@ func (r *reconcilerImpl) updateStatus(ctx context.Context, logger *zap.SugaredLo
// updateFinalizersFiltered will update the Finalizers of the resource.
// TODO: this method could be generic and sync all finalizers. For now it only
// updates defaultFinalizerName or its override.
-func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1.CronJob, desiredFinalizers sets.Set[string]) (*v1.CronJob, error) {
+func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource *v1.CronJob, desiredFinalizers sets.String) (*v1.CronJob, error) {
// Don't modify the informers copy.
existing := resource.DeepCopy()
var finalizers []string
// If there's nothing to update, just return.
- existingFinalizers := sets.New[string](existing.Finalizers...)
+ existingFinalizers := sets.NewString(existing.Finalizers...)
if desiredFinalizers.Has(r.finalizerName) {
if existingFinalizers.Has(r.finalizerName) {
@@ -361,7 +361,7 @@ func (r *reconcilerImpl) updateFinalizersFiltered(ctx context.Context, resource
}
// Remove the finalizer.
existingFinalizers.Delete(r.finalizerName)
- finalizers = sets.List(existingFinalizers)
+ finalizers = existingFinalizers.List()
}
mergePatch := map[string]interface{}{
@@ -395,7 +395,7 @@ func (r *reconcilerImpl) setFinalizerIfFinalizer(ctx context.Context, resource *
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
// If this resource is not being deleted, mark the finalizer.
if resource.GetDeletionTimestamp().IsZero() {
@@ -414,7 +414,7 @@ func (r *reconcilerImpl) clearFinalizer(ctx context.Context, resource *v1.CronJo
return resource, nil
}
- finalizers := sets.New[string](resource.Finalizers...)
+ finalizers := sets.NewString(resource.Finalizers...)
if reconcileEvent != nil {
var event *reconciler.ReconcilerEvent
|
|
verify / Verify Deps and Codegen
Restore cache failed: Dependencies file is not found in /home/runner/work/pkg/pkg. Supported file pattern: go.sum
|