Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gobwas/ws instead of gorilla/websocket #2730

Closed
wants to merge 4 commits into from

Conversation

Gekko0114
Copy link

@Gekko0114 Gekko0114 commented Apr 22, 2023

Changes

https://github.com/gorilla/websocket is deprecated and unmaintained.
We should switch to something that is and ensure everything works as expected (ie. draining in queue proxy etc).
In this PR, I've replaced gorilla/websocket with gobwas/ws.

  • 🧹 Update or clean up current behavior

/kind deprecation

Fixes #2727 , knative/serving#13824

Release Note

use `gobwas/ws` instead of `gorilla/websocket`

Special notes for your reviewer
Thank you for reviewing this PR.
Please let me know if I have made any mistakes or if there are any improvements that could be made.
I am not an expert in Knative or WebSocket, so I would appreciate it if you could provide me with some guidance.

@knative-prow knative-prow bot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Apr 22, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gekko0114
Once this PR has been reviewed and has the lgtm label, please assign lionelvillard for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from creydr and jsanin-vmw April 22, 2023 05:22
@knative-prow
Copy link

knative-prow bot commented Apr 22, 2023

Welcome @Gekko0114! It looks like this is your first PR to knative/pkg 🎉

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 22, 2023

Hi @Gekko0114. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gekko0114
Copy link
Author

Hi @dprotaso,

I've created this PR for fixing this issue.
Could you have a look?
Thanks,

@dprotaso
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2023
@dprotaso
Copy link
Member

Are you able to create a WIP in the downstream serving repo to test the changes you've made - ie. use the go replace directive to point to your fork

@Gekko0114
Copy link
Author

Sure. I'll do it.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 96.77% and project coverage change: +0.04 🎉

Comparison is base (300df43) 81.53% compared to head (cf65568) 81.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2730      +/-   ##
==========================================
+ Coverage   81.53%   81.57%   +0.04%     
==========================================
  Files         163      163              
  Lines       10018    10030      +12     
==========================================
+ Hits         8168     8182      +14     
+ Misses       1606     1605       -1     
+ Partials      244      243       -1     
Impacted Files Coverage Δ
websocket/connection.go 96.85% <96.77%> (+3.00%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gekko0114
Copy link
Author

/retest-required

@dprotaso
Copy link
Member

Closing this for now - seems like RedHat might become owners of gorilla/websocket - so we'll pause this for now

knative/serving#13824 (comment)

@dprotaso dprotaso closed this May 15, 2023
@dprotaso
Copy link
Member

Closing this for now - seems like RedHat might become owners of gorilla/websocket - so we'll pause this for now

knative/serving#13824 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop use of https://github.com/gorilla/websocket
2 participants