-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use gobwas/ws instead of gorilla/websocket #2730
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Gekko0114 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Gekko0114! It looks like this is your first PR to knative/pkg 🎉 |
Hi @Gekko0114. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @dprotaso, I've created this PR for fixing this issue. |
/ok-to-test |
Are you able to create a WIP in the downstream serving repo to test the changes you've made - ie. use the go |
Sure. I'll do it. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
+ Coverage 81.53% 81.57% +0.04%
==========================================
Files 163 163
Lines 10018 10030 +12
==========================================
+ Hits 8168 8182 +14
+ Misses 1606 1605 -1
+ Partials 244 243 -1
☔ View full report in Codecov by Sentry. |
/retest-required |
Closing this for now - seems like RedHat might become owners of gorilla/websocket - so we'll pause this for now |
Closing this for now - seems like RedHat might become owners of gorilla/websocket - so we'll pause this for now |
Changes
https://github.com/gorilla/websocket is deprecated and unmaintained.
We should switch to something that is and ensure everything works as expected (ie. draining in queue proxy etc).
In this PR, I've replaced
gorilla/websocket
withgobwas/ws
./kind deprecation
Fixes #2727 , knative/serving#13824
Release Note
Special notes for your reviewer
Thank you for reviewing this PR.
Please let me know if I have made any mistakes or if there are any improvements that could be made.
I am not an expert in
Knative
orWebSocket
, so I would appreciate it if you could provide me with some guidance.