Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump K8s dependencies to v0.28.5 and set K8s min-version to 1.27 #2928

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Jan 8, 2024

Changes

Fixes #2902

Release Note

The minimal required kubernetes version to use `knative/pkg` is now v1.27.0

@knative-prow knative-prow bot requested review from aslom and evankanderson January 8, 2024 12:35
@knative-prow knative-prow bot added area/test-and-release size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 8, 2024
@skonto
Copy link
Contributor

skonto commented Jan 8, 2024

fatal: ambiguous argument 'third_party/VENDOR-LICENSE/golang.org/x/sys/unix/LICENSE': unknown revision or path not in the working tree.

I think that was faced before right?

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a459076) 81.80% compared to head (529d282) 81.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2928   +/-   ##
=======================================
  Coverage   81.80%   81.80%           
=======================================
  Files         167      167           
  Lines       10231    10231           
=======================================
  Hits         8369     8369           
  Misses       1614     1614           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hack/update-codegen.sh Outdated Show resolved Hide resolved
@dprotaso
Copy link
Member

dprotaso commented Jan 8, 2024

Also can we rebase on - #2915

@ReToCode
Copy link
Member Author

ReToCode commented Jan 9, 2024

Merged the changes in hack and rebased on top of latest main

@dprotaso
Copy link
Member

dprotaso commented Jan 9, 2024

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
Copy link

knative-prow bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 21d8c37 into knative:main Jan 9, 2024
37 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump K8s min version to v1.27
3 participants