This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
Added Token/Tokenizer and PostaggedToken/PosTagger Serialization #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The serialization scheme is The@0 DT NP \t big@4 JJ NP --- Token -------- PostaggedToken ----------- ChunkedToken
| def read(str: String): PostaggedToken = { | ||
| try{ | ||
| val token = Token.serialization.read(str) | ||
| val info = str.split(" ") |
There was a problem hiding this comment.
I would write this as val postag = str.split(" ") match { case Array(postag) => postag }.
You could add a case here to handle the exception and give an informative error too (i.e. case _ => throw new MatchError)
|
|
Ok thanks for the comments, I'll make these changes, and then do the same for ChunkedToken. |
|
Awesome--it'll be great to have this. |
|
Don't merge yet, I'm going to change the code so that it won't break if there is an '@' in the token string. |
|
Cool. Do we |
|
Ok, good to merge. ChunkedToken and PostaggedToken already required that posTag and chunk do not contain whitespace. |
schmmd
added a commit
that referenced
this pull request
Oct 24, 2013
Added Token/Tokenizer and PostaggedToken/PosTagger Serialization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serialization scheme is
The@0 DT NP-DT \t big@4 JJ NP-JJ