Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra source files in the source tarball #169

Merged
merged 2 commits into from
Jun 1, 2014
Merged

Add extra source files in the source tarball #169

merged 2 commits into from
Jun 1, 2014

Conversation

dridi
Copy link
Contributor

@dridi dridi commented Jun 1, 2014

Hi,

It's been quite a while, and I just noticed that I'm two releases behind. ShellCheck is still at 0.3.1 on Hackage, and I was hoping you'd keep uploading releases there.

This patch will add to the source tarball the missing bits I need to let all the heavy lifting to Fedora's Hackage/Cabal tooling. I will update ShellCheck to 0.3.3 for Fedora soon and I hope I'll build the next release directly from Hackage :-)

Cheers,
Dridi

This way ShellCheck can be entirely built (including the test suite)
from the Hackage tarball.

The source tarball can be generated using:

    cabal sdist
@koalaman
Copy link
Owner

koalaman commented Jun 1, 2014

Both ShellCheck 0.3.2 and 0.3.3 have been available on Hackage:
http://hackage.haskell.org/package/ShellCheck-0.3.3

I'll be happy to add anything that aids your packaging!

You'll want to take a look at the current HEAD though, and particularly the commits from #165 , which remove a lot of the files you're referencing.

@dridi
Copy link
Contributor Author

dridi commented Jun 1, 2014

Both ShellCheck 0.3.2 and 0.3.3 have been available on Hackage:

This is embarrassing :-)

I don't understand why I got 404 responses with wget when I tried to download the source tarballs from Hackage (yes I'm so lazy I didn't feel like opening a browser=). I also need to understand why Fedora's infra didn't notify me like it did for previous versions.

I'll be happy to add anything that aids your packaging!

Thanks, I really appreciate your help.

You'll want to take a look at the current HEAD though, and particularly the commits from #165 , which remove a lot of the files you're referencing.

Embarrassing again, I initially forked the tag v0.3.3 but figured I'd better rebase against master to keep you're history as flat as possible... I didn't check after the rebase...

koalaman added a commit that referenced this pull request Jun 1, 2014
Add extra source files in the source tarball
@koalaman koalaman merged commit 61531cb into koalaman:master Jun 1, 2014
@dridi dridi deleted the hackage branch June 1, 2014 19:59
@dridi
Copy link
Contributor Author

dridi commented Jun 1, 2014

Just in case, could you please notify me of the next release with a comment in this PR ?

@koalaman
Copy link
Owner

koalaman commented Jun 1, 2014

I can try, but I'm highly likely to forget. Do you happen to use an RSS reader? If so, you can subscribe to https://github.com/koalaman/shellcheck/releases.atom . If not, there are some rss-to-email services which I'm sure are more reliable than I am.

@dridi
Copy link
Contributor Author

dridi commented Jun 1, 2014

Subscribed! Thanks again :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants