Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: bad comment #5372

Merged
merged 1 commit into from
Dec 18, 2024
Merged

temp: bad comment #5372

merged 1 commit into from
Dec 18, 2024

Conversation

rgraber
Copy link
Contributor

@rgraber rgraber commented Dec 18, 2024

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

📖 Description

👷 Description for instance maintainers

💭 Notes

👀 Preview steps

Bug template:

  1. ℹ️ have an account and a project
  2. do this
  3. do that
  4. 🔴 [on main] notice that this isn't anywhere BUT it should be here
  5. 🟢 [on PR] notice that this is here

Feature/no-change template:

  1. ℹ️ have account and a project
  2. do this
  3. do that
  4. 🟢 notice that this is there
  5. do that another thing
  6. 🟢 notice that this changed like that

@rgraber rgraber merged commit 530e6ea into rsgraber/fake-main Dec 18, 2024
3 of 4 checks passed
@rgraber rgraber deleted the rsgraber/fake-problem branch December 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant