Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase FileField maximum length to 380 characters #5390

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Dec 19, 2024

📣 Summary

Increased the maximum length of FileField models from the default to 380 characters.

📖 Description

The maximum length for FileField objects has been increased to 380 characters (100 by default). This change allows longer file paths to be stored, ensuring compatibility with deeply nested directories or longer file names that might have been truncated previously.

@noliveleger noliveleger force-pushed the increase-default-files-path-length branch from 77817cb to eab6102 Compare December 19, 2024 21:38
@noliveleger noliveleger changed the title Increase FileField objects max_length to 380 fix: increase FileField maximum length to 380 characters Dec 19, 2024
@noliveleger noliveleger requested a review from Guitlle December 19, 2024 21:46
@noliveleger noliveleger self-assigned this Dec 19, 2024
@noliveleger noliveleger marked this pull request as ready for review December 19, 2024 21:46
@noliveleger noliveleger requested a review from jnm as a code owner December 19, 2024 21:46
@noliveleger noliveleger removed the request for review from jnm December 19, 2024 21:47
Copy link
Contributor

@Guitlle Guitlle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but not sure about the risk that the migrations can have

@noliveleger noliveleger merged commit 507c28f into main Dec 20, 2024
4 checks passed
@noliveleger noliveleger deleted the increase-default-files-path-length branch December 20, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants